Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): Add IE 11 support #288

Merged
merged 1 commit into from
Jun 4, 2018
Merged

fix(browser): Add IE 11 support #288

merged 1 commit into from
Jun 4, 2018

Conversation

danoc
Copy link
Contributor

@danoc danoc commented May 26, 2018

This adds IE 11 support as well as support for older versions of Uglify.

It does so by transpiling stringify-object with babel.

Closes #211, #285

@ghost
Copy link

ghost commented May 26, 2018

There were the following issues with this Pull Request

  • Commit: d2b084f
    • ✖ message may not be empty
      , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

1 similar comment
@ghost
Copy link

ghost commented May 26, 2018

There were the following issues with this Pull Request

  • Commit: d2b084f
    • ✖ message may not be empty
      , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@danoc
Copy link
Contributor Author

danoc commented May 26, 2018

The glob pattern doesn't seem to work. It's transpiling everything in node_modules.

Does anyone have tips on how to make it only exclude stringify-object?

@vvo
Copy link
Contributor

vvo commented May 28, 2018

maybe @pascalduez knows and can help here?

@vvo
Copy link
Contributor

vvo commented May 28, 2018

@danoc What you could do is use include instead of exclude or mix them? Might be easier than trying to find the right glob pattern

@pascalduez
Copy link
Contributor

exclude: 'node_modules/!(stringify-object)/**'

This adds IE 11 support as well as support for older versions of Uglify.

It does so by transpiling `stringify-object` with babel.

Closes #211, #285
@danoc
Copy link
Contributor Author

danoc commented May 29, 2018

Great, that worked well. Here's a diff of the CJS output:

https://www.diffchecker.com/RPnK1ARg

Notice that only stringify-object is affected.

Copy link
Collaborator

@armandabric armandabric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! I miss it in my previous PR.

@danoc
Copy link
Contributor Author

danoc commented Jun 1, 2018

Thanks @Spy-Seth! @vvo — I think this one is good to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants