This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
docs(hooks): make sure example runs without ts errors #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't understand why ci wasn't red before now, but in https://app.circleci.com/pipelines/github/algolia/react-instantsearch/1614/workflows/de241179-b866-4dc6-b576-0a4de456f2fb/jobs/47848 it is
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3d5c797:
|
|
can't tell whether this is the "false" passing tsc or the "right" passing one, and what makes CI pass even though tsc fails locally on master for me (is it related to workspaces/install/build missing?) |
|
✔️ Deploy Preview for react-instantsearch ready! 🔨 Explore the source changes: 3d5c797 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-instantsearch/deploys/619cebd9cd68c10007060896 😎 Browse the preview: https://deploy-preview-3207--react-instantsearch.netlify.app |
dhayab
approved these changes
Nov 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all TS errors in example repo
I don't understand why ci wasn't red before now, but in https://app.circleci.com/pipelines/github/algolia/react-instantsearch/1614/workflows/de241179-b866-4dc6-b576-0a4de456f2fb/jobs/47848 it is
Result
no more ts errors in hooks example and ci green