This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change is motivated from a very specific use case:
I have a custom form input component which includes a
SearchBox
, so I my own<form>
tag is wrapping the<form>
that's withinSearchBox
. This leads to an unexpected form submission when pressing the Enter key in the search box text input.I've already tried
preventDefault
andstopPropagation
in theonSubmit
callback available forSearchBox
but it seems the way React handles events makes this useless. Getting aref
for the form allowed me to stop the submit event by usingaddEventListener
on theref.current
element.Since there's already an
inputRef
I think having aformRef
won't hurt and would help others that may find themselves in a similar form nesting situation.Result
A new
formRef
prop analog to currentinputRef
is added toSearchBox
.