This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
docs(example-ssr): use cjs imports #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example is ran using node without esm, and webpack also isn't set up for proper esm, so this errors in modern node (14+) if we use esm. Setting up for proper esm (type module etc) wouldn't be representative for most users, so we'll fall back to cjs CR-2214
Haroenv
requested review from
a team,
dhayab and
FabienMotte
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9d2fa92:
|
✅ Deploy Preview for react-instantsearch ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dhayab
suggested changes
Oct 19, 2022
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
dhayab
approved these changes
Oct 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The example is ran using node without esm, and webpack also isn't set up for proper esm, so this errors in modern node (14+) if we use esm.
Setting up for proper esm (type module etc) wouldn't be representative for most users, so we'll fall back to cjs
CR-2214
Result
using cjs imports in hooks-ssr example