You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
install ship.js 0.23.3
in ship.config.js, add pullRequestReviewers: ['vinayakkulkarni']
npm run release
Expected behavior
A new automated PR should be created with default reviewers.
Screenshots
remote:
remote: Create a pull request for'releases/v0.1.0' on GitHub by visiting:
remote: https://github.com/<redacted>/pull/new/releases/v0.1.0
remote:
To https://github.com/<redacted>* [new branch] releases/v0.1.0 -> releases/v0.1.0
› Creating a pull request.
$ git remote prune origin
octokit.pulls.createReviewRequest() has been renamed to octokit.pulls.requestReviewers()
Deprecation: [@octokit/request-error] `error.code` is deprecated, use `error.status`.
at RequestError.get (/Users/vinayak/Development/Work/OSS/<redacted>/node_modules/@octokit/request-error/dist-node/index.js:57:21)
at Proxy.cli (/Users/vinayak/Development/Work/OSS/<redacted>/node_modules/shipjs/src/cli.js:50:15)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async /Users/vinayak/Development/Work/OSS/<redacted>/node_modules/shipjs/bin/shipjs:7:5
RequestError [HttpError]: Review cannot be requested from pull request author.
at /Users/vinayak/Development/Work/OSS/<redacted>/node_modules/@octokit/request/dist-node/index.js:86:21
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async /Users/vinayak/Development/Work/OSS/<redacted>/node_modules/shipjs/src/step/prepare/createPullRequest.js:82:7
at async default (/Users/vinayak/Development/Work/OSS/<redacted>/node_modules/shipjs/src/step/prepare/createPullRequest.js:20:3)
at async prepare (/Users/vinayak/Development/Work/OSS/<redacted>/node_modules/shipjs/src/flow/prepare.js:112:30)
at async Proxy.cli (/Users/vinayak/Development/Work/OSS/<redacted>/node_modules/shipjs/src/cli.js:48:5)
at async /Users/vinayak/Development/Work/OSS/<redacted>/node_modules/shipjs/bin/shipjs:7:5 {
status: 422,
Environment (please complete the following information):
environment: (your local machine, CircleCI, Travis CI, etc.)
node -v: v16.3.0
npm -v: 7.17.0
Ship.js version: 0.23.3
Additional context
This is due to octokit's deprecation of createReviewRequest, instead it's requestReviewers
The text was updated successfully, but these errors were encountered:
Hello @vinayakkulkarni,
Although your PR seems correct, I don't think it will fix your issue.
That's just a warning, but the real error that stopped your release process was:
RequestError [HttpError]: Review cannot be requested from pull request author.
You're assigning yourself as a reviewer and GitHub doesn't allow it. That's why it failed.
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
pullRequestReviewers: ['vinayakkulkarni']
Expected behavior
A new automated PR should be created with default reviewers.
Screenshots
Environment (please complete the following information):
node -v
: v16.3.0npm -v
: 7.17.0Additional context
This is due to octokit's deprecation of createReviewRequest, instead it's requestReviewers
The text was updated successfully, but these errors were encountered: