Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove deprecated method from octokit's rest API #957

Closed
wants to merge 1 commit into from
Closed

fix: remove deprecated method from octokit's rest API #957

wants to merge 1 commit into from

Conversation

vinayakkulkarni
Copy link
Contributor

Haroenv
Haroenv approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems correct based on https://octokit.github.io/rest.js/v18#pulls-request-reviewers

@eunjae-lee
Copy link
Contributor

I just checked and it seems the method requestReviewers is added at @octokit/rest@18 while we use 17 at the moment. I'll close this PR for the moment, but feel free to open again if you want to continue.

It will include the work of upgrading @octokit/rest to v18 and check what's breaking/changed.

@eunjae-lee eunjae-lee closed this Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pullRequestReviewers octokit deprecation error
3 participants
@vinayakkulkarni @eunjae-lee @Haroenv