fix(types): complete used interface of JSX fallback #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
force-pushed
the
fix/more-no-preact
branch
from
a24d516
to
9d6ca6d
Compare
Haroenv
changed the title
sarahdayan
reviewed
Oct 12, 2022
Haroenv
commented
Oct 12, 2022
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
aymeric-giraudet
approved these changes
Oct 12, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits:
9d6ca6d: adds a new task to CI to test that types can run without an implementation of JSX
The ci failure is expected, as it is fixed in next commit
89c98ef: fixes the types introduced in #13 further, to also implement all implicit usage of JSX
FX-1855