fix(types): don't pollute globals with JSX #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2023
|
Thank you for this @Haroenv - we also stumbled upon it!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #13 and #16
Essentially, in adding #16, we wanted to ensure everything built without JSX, but what we only want to do is ensure everything is usable without JSX (like Angular InstantSearch, which I confirmed works with the new output of files, but you can definitely double check)
fixes #28
future fix for algolia/instantsearch#5853 once upstreamed
I think in the future as well it could be interesting to put this repo inside InstantSearch monorepo