fix: authorize global assignment of window in PostCSS file
#150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the configuration file refers to
window, we need to shim it so it doesn't break when processed with Node during the build step. This is a violation of ESLint rules because we shall not assign to native objects or read-only global variables, but it's okay in our case.What's next
Depending on what browsers we decide to support in the future, we may want to leverage
globalThisinstead. We currently cannot since we support IE11, but since Microsoft has decided to drop support, and depending on InstantSearch decisions regarding browser support, we may want to follow that as well.