Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement initial Hive to Sembast migration #11

Merged
merged 1 commit into from Oct 15, 2021

Conversation

Bringoff
Copy link
Collaborator

@Bringoff Bringoff commented Oct 7, 2021

Related to #10

@Bringoff Bringoff force-pushed the hive-to-sembast-migration branch 7 times, most recently from dfeac29 to a9d48cc Compare October 8, 2021 10:34
@Bringoff Bringoff requested a review from algodave October 8, 2021 10:34
@Bringoff Bringoff self-assigned this Oct 8, 2021
@Bringoff Bringoff marked this pull request as ready for review October 8, 2021 12:43
Copy link
Member

@algodave algodave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @Bringoff - Only a couple small things to address before merging, see inline comments. Thanks!

lib/src/adapters/persistent_json_api.dart Outdated Show resolved Hide resolved
lib/src/db_adapters/json_api.dart Outdated Show resolved Hide resolved
@Bringoff
Copy link
Collaborator Author

@algodave thanks for the review, just pushed the update with requested changes

@algodave
Copy link
Member

@Bringoff Thank you for the great job here, I'm merging!

@algodave algodave merged commit d1eb2c8 into master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants