Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unplanned] Go template bugfixes #112

Closed
EvanJRichard opened this issue Feb 3, 2020 · 0 comments
Closed

[unplanned] Go template bugfixes #112

EvanJRichard opened this issue Feb 3, 2020 · 0 comments
Assignees
@EvanJRichard
Labels
8 Story Point Estimate (Algorand internal use only)

Comments

@EvanJRichard
Copy link
Contributor

EvanJRichard commented Feb 3, 2020 •
edited
Loading

DynamicFee: Fix bug where the grouped transactions were presented to the contract in the wrong order. Fix incorrect lsig/txn building.
Split: Remove precise flag and change corresponding error. Fix rounding error in amount calculation. Fix bug where ratn and ratd were inversed. GetSendFundsTransaction becomes static-like GetSplitFundsTransaction, which accepts a complete contract.
PeriodicPayment: Fix bug where the maximum fee passed to the contract was then used as the payment transaction's fee-per-byte.
LimitOrder: Fix bug where the transactions were being presented to the contract in the wrong order.
HTLC: Add getter for HTLC-unlocking txn.

Update all unit tests.
@EvanJRichard EvanJRichard self-assigned this Feb 3, 2020
@EvanJRichard EvanJRichard changed the title Fix LimitOrder implementation: incorrect funds ratio and doesn't accept contract and no golden for output transactions Fix Split implementation: incorrect funds ratio and doesn't accept contract and no golden for output transactions Feb 3, 2020
@EvanJRichard EvanJRichard changed the title Fix Split implementation: incorrect funds ratio and doesn't accept contract and no golden for output transactions [found work] Fix Split implementation: incorrect funds ratio, doesn't accept contract, no golden for output transactions Feb 5, 2020
@EvanJRichard EvanJRichard changed the title [found work] Fix Split implementation: incorrect funds ratio, doesn't accept contract, no golden for output transactions [unplanned] Fix Split implementation: incorrect funds ratio, doesn't accept contract, no golden for output transactions Feb 5, 2020
@EvanJRichard EvanJRichard changed the title [unplanned] Fix Split implementation: incorrect funds ratio, doesn't accept contract, no golden for output transactions [unplanned] Go template bugfixes Feb 5, 2020
@EvanJRichard EvanJRichard mentioned this issue Feb 5, 2020
Merged
@EvanJRichard EvanJRichard added the 8 Story Point Estimate (Algorand internal use only) label Feb 5, 2020
EvanJRichard added a commit that referenced this issue Feb 7, 2020
@EvanJRichard
Contract Template hotfixes and updates (#113)
8178899 
Review: #113
Resolves: #112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvanJRichard EvanJRichard

Labels
8 Story Point Estimate (Algorand internal use only)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EvanJRichard