Limit order TEAL template #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 6, 2019 10:47
…sed quite yet, add them back in when we need them
rotemh
reviewed
Dec 16, 2019
templates/limitOrder.go
Outdated
| } | ||
|
|
||
| // MakeLimitOrder allows a user to exchange some number of N assets for D algos. | ||
| // This is a contract account. |
There was a problem hiding this comment.
This is a bit of a weird comment here that makes much more sense in the TEAL code.
rotemh
suggested changes
Dec 16, 2019
templates/limitOrder.go
Outdated
| return signedGroup, nil | ||
| } | ||
|
|
||
| // MakeLimitOrder allows a user to exchange some number of N assets for D algos. |
There was a problem hiding this comment.
This line and line 75 are contradicting
rotemh
approved these changes
Dec 22, 2019
| // the first payment sends money (Algos) from contract to the recipient (we'll call him Buyer), closing the rest of the account to Owner | ||
| // the second payment sends money (the asset) from Buyer to the Owner | ||
| // these transactions will be rejected if they do not meet the restrictions set by the contract | ||
| func (lo LimitOrder) GetSwapAssetsTransaction(assetAmount uint64, contract, secretKey []byte, fee, algoAmount, firstRound, lastRound uint64, genesisHash []byte) ([]byte, error) { |
There was a problem hiding this comment.
This one does the correct thing!
There was a problem hiding this comment.
we should probably rename algoAmount to microAlgoAmount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This template implements
limit-order-a.teal.implfromgo-algorand.Testing
Automatic unit/sdk testing. Added a golden test for program and address.
See also
#98