Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error formatting names convention #154

Closed
jsign opened this issue Jul 12, 2019 · 3 comments
Closed

Error formatting names convention #154

jsign opened this issue Jul 12, 2019 · 3 comments
Labels

Comments

@jsign
Copy link
Contributor

jsign commented Jul 12, 2019

In cmd/goal/messages.go I noticed that the error formatting strings don't follow a naming convention. Some of them prefix err, error, or suffix Error.

I'm not sure if there's the desired naming convention, which helps using hints while coding (e.g: since all errors start with err, and ide can hint existing errors). Possibly, this may apply to more places.

If that's the case, this could be tagged as an easy issue for someone to get involved in the code?

@Vervious Vervious added 1 good first issue / help wanted Good for newcomers and new contributors. quality Improve code quality or style labels Jul 13, 2019
@howjmay
Copy link

howjmay commented Aug 23, 2019

May I take this issue and unite the suffix into err?

@Marcuccio
Copy link

It seems already closed, am I wrong?

algorandskiy pushed a commit to algorandskiy/go-algorand that referenced this issue Jul 7, 2020
@ian-algorand ian-algorand added FDE and removed 1 good first issue / help wanted Good for newcomers and new contributors. quality Improve code quality or style labels Jul 29, 2020
@ian-algorand
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants