-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libsodium-fork should be a submodule rather than cloned in-tree #20
Comments
I think submodules are somewhat clunky. An alternative proposal would be to fork off |
If I may add my own experience from wrestling with this same issue in the past. I would also like to preface this by saying that the code base I was working on consisted of about 120 "subrepos" and tens of millions of LOC so it might be overkill for The first thing we looked at is What we came up with eventually relied on Circling back to your dilemma, and this is where I'll show my ignorance as an outsider, these would be my questions to you: Do you really need to import the source? Can you just have prebuilt library releases in a separate repo and just link them? Does it matter if you have a monorepo or two sister repos? If nothing else, I hope this gives you some ideas or you have a good laugh :) |
@jecassis, I think that there are two requirement that we absolutely need :
Reflecting back, I can recall several companies I worked for, which failed with the above ( mystery library that cannot be rebuilt, etc.). These scenarios rarely plays into the company best interest. |
Commendable goals, to be sure. Thanks for the explanation! |
Fix some documentation in `goal app`.
The Dev Ops team has determined that this is no longer applicable, we won't be implementing this issue. Also, no activity for 2 years, stale issue. |
I have some concerns about this too. It appears that you are falling behind upstream libsodium as well. Wouldn't a patchfile or something make more sense to be able to integrate with upstream directly? |
At the moment
libsodium-fork
is just checked into thego-algorand
tree directly. This is a maintenance burden and hurts auditability. We should switch to includinglibsodium-fork
as a git submodule.To avoid a significant fraction of submodule terribleness, this should probably look like the following:
go-algorand/submodules/
directory and put github.com/algorand/libsodium ingo-algorand/submodules/libsodium-fork
as a submodule.go-algorand/crypto/libsodium-fork
a symlink to../submodules/libsodium-fork
. This will let us switch between branches without submodules and branches with submodules without horribly confusing git.git submodule update --init
to the makefile, to be done before libsodium buildThe text was updated successfully, but these errors were encountered: