Add initial golangci-lint action #2647
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2647 +/- ##
==========================================
+ Coverage 47.07% 47.08% +0.01%
==========================================
Files 349 349
Lines 55858 55858
==========================================
+ Hits 26294 26300 +6
+ Misses 26617 26611 -6
Partials 2947 2947
Continue to review full report at Codecov.
|
|
Woah, this is really cool! |
|
Hrmm, too bad, reviewdog has not yet implemented the ability to pass through the different golangci-lint severity levels (errors vs warnings) to Github checks yet reviewdog/reviewdog#343 |
This reverts commit 435da04.
Parameterize no_output_timeout and -short in the general commands on the circle config file to reduce duplicate code.
Add partition to daemon/algod/api/server/router_test.go
Right now a system.json file is not created when setting up systemd through the setup-systemd.sh script. Therefore, users aren't letting their nodes know that the algod process will be managed with systemd. This change modifies the systemd configuration file to create the system.json file in the data directory.
algojack
assigned algojack and unassigned cce, onetechnical, egieseke, bricerisingalgorand and algobarb
algojack
requested review from
algobarb,
bricerisingalgorand,
egieseke and
onetechnical
…/gha-golangci-lint
There was a problem hiding this comment.
This is pretty cool.
So we're adding in the ReviewDog workflow which would act on github actions and it calls the tests directly, separating errors from warnings. So we moved partition-test away from .golangci.yml tests to .golangci-warnings.yml so that we only get warnings from reviewdogs instead of errors on the PRs right? What does changing .golangci.yml tests from true to false do?
Tests: true -> false, tells the linters not to check test files that end in "_test.go". We have it true in warnings but false in blocking errors. And even in warnings we only limit them to partitiontest linter by excluding all other linters. |
Summary
Run golangci-lint from Github actions using https://github.com/golangci/golangci-lint-action
Test Plan
Adds new check to PRs and merges.