Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: fix TestStartAndStop #2757

Merged

Conversation

algonautshant
Copy link
Contributor

Summary

This fixes and enabled the test TestStartAndStop.

Test Plan

@algonautshant algonautshant linked an issue Aug 17, 2021 that may be closed by this pull request
@algonautshant algonautshant self-assigned this Aug 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #2757 (9e00cf8) into master (3d3feb5) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2757   +/-   ##
=======================================
  Coverage   47.09%   47.09%           
=======================================
  Files         349      349           
  Lines       55858    55858           
=======================================
+ Hits        26306    26307    +1     
+ Misses      26604    26602    -2     
- Partials     2948     2949    +1     
Impacted Files Coverage Δ
agreement/cryptoVerifier.go 75.73% <0.00%> (-2.21%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
network/requestTracker.go 71.12% <0.00%> (-0.44%) ⬇️
network/wsNetwork.go 60.73% <0.00%> (-0.19%) ⬇️
ledger/acctupdates.go 62.30% <0.00%> (-0.09%) ⬇️
catchup/service.go 69.35% <0.00%> (ø)
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
rpcs/txSyncer.go 80.00% <0.00%> (+16.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d3feb5...9e00cf8. Read the comment docs.

@tsachiherman tsachiherman changed the title Fix TestStartAndStop testing: fix TestStartAndStop Aug 23, 2021
@tsachiherman tsachiherman merged commit 849e924 into algorand:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update and unfilter TestStartAndStop
3 participants