Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: fixing a typo in e2e.sh for integration tests #2761

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

algojack
Copy link
Contributor

@algojack algojack commented Aug 17, 2021

Summary

fixing a typo in e2e.sh for integration tests

Test Plan

Tested in CircleCI/TravisCI tests

algojack and others added 2 commits August 17, 2021 11:35
(cherry picked from commit e00cf47)
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #2761 (7668bd1) into master (66e54d9) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2761   +/-   ##
=======================================
  Coverage   47.12%   47.12%           
=======================================
  Files         349      349           
  Lines       56326    56326           
=======================================
+ Hits        26541    26544    +3     
+ Misses      26814    26811    -3     
  Partials     2971     2971           
Impacted Files Coverage Δ
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
network/requestTracker.go 70.25% <0.00%> (-0.87%) ⬇️
ledger/acctupdates.go 62.46% <0.00%> (ø)
network/wsNetwork.go 61.21% <0.00%> (+0.28%) ⬆️
cmd/tealdbg/debugger.go 73.86% <0.00%> (+1.00%) ⬆️
network/wsPeer.go 77.15% <0.00%> (+2.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e54d9...7668bd1. Read the comment docs.

Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved so that we can fix the integration tests for master branch.

@tsachiherman tsachiherman merged commit f774e7e into master Aug 17, 2021
@tsachiherman tsachiherman deleted the jack/typo-in-e2e-sh branch August 17, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants