Display extra pages in goal info commands #2763
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2763 +/- ##
==========================================
- Coverage 47.12% 47.09% -0.03%
==========================================
Files 349 349
Lines 56326 56348 +22
==========================================
- Hits 26541 26535 -6
- Misses 26814 26838 +24
- Partials 2971 2975 +4
Continue to review full report at Codecov.
|
| if [[ $RES != *"${PROGHASH}"* ]]; then | ||
| date '+app-extra-pages-test FAIL the application info should succeed %Y%m%d_%H%M%S' | ||
| date '+app-extra-pages-test FAIL the application approval program hash is incorrect %Y%m%d_%H%M%S' |
There was a problem hiding this comment.
Might be nice to migrate toward doing this at the top of e2e .sh programs
filename=$(basename "$0")
scriptname="${filename%.*}"
date "+${scriptname} start %Y%m%d_%H%M%S"
So you can use $scriptname here (and elsewhere). No big deal, just makes copying testing for modification easier.
| @@ -31,7 +31,7 @@ import ( | |||
| "github.com/algorand/go-algorand/config" | |||
| "github.com/algorand/go-algorand/crypto" | |||
| "github.com/algorand/go-algorand/crypto/passphrase" | |||
| v1 "github.com/algorand/go-algorand/daemon/algod/api/spec/v1" | |||
| generatedV2 "github.com/algorand/go-algorand/daemon/algod/api/server/v2/generated" | |||
There was a problem hiding this comment.
Can you summarize what we're doing with versioning that forces changes in this PR? We don't have to increment the version for changes like this, right? Maybe you're just migrating to the new version that we previously had to do?
There was a problem hiding this comment.
Actually I had to upgrade to using the v2 endpoint because v1 does not return extra pages values for accounts.
| for _, createdAsset := range createdAssets { | ||
| name := "<unnamed>" | ||
| if createdAsset.Params.Name != nil { | ||
| _, name = unicodePrintable(*createdAsset.Params.Name) |
There was a problem hiding this comment.
It may be unnecessary to pipe the string fields through unicodePrintable after #2555, but I've left them in just in case.
Summary
With this PR, the commands
goal app info,goal account info, andgoal account list --infonow display the number of extra pages an application has.For example, the following were executed on a private network where apps 1, 2, 3, 4 have 1, 2, 3, 0 extra pages, respectively.
Test Plan
Modified existing e2e test and expect test. (I know expect tests aren't currently running, but it passed locally.)