Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

per-client RAM measurement scripts #2783

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

brianolson
Copy link
Contributor

Summary

new scripts runNodeHost.py and nodeHostTarget.py manage starting a new ec2 node with algod (or several) pointed at a specific relay so that we can test per-client usage on that one relay.

improve goal: don't crash if kmd isn't present when we don't need it

tweaks to other heapWatch scripts for measuring this data.

Test Plan

This is manual testing code. I used it to run test clusters.

improve exception handling
wip - towards launching participating nodes with stake
improve goal
don't crash if kmd isn't present when we don't need it
updates for measuring per-client ram usage in a relay
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #2783 (2614bc0) into master (f774e7e) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2783   +/-   ##
=======================================
  Coverage   47.10%   47.10%           
=======================================
  Files         349      349           
  Lines       56326    56336   +10     
=======================================
+ Hits        26533    26538    +5     
- Misses      26817    26825    +8     
+ Partials     2976     2973    -3     
Impacted Files Coverage Δ
cmd/goal/account.go 14.69% <0.00%> (-0.09%) ⬇️
cmd/goal/commands.go 10.81% <0.00%> (-0.26%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
cmd/tealdbg/debugger.go 72.86% <0.00%> (-1.01%) ⬇️
catchup/service.go 69.35% <0.00%> (-0.78%) ⬇️
network/wsPeer.go 74.37% <0.00%> (-0.56%) ⬇️
data/transactions/verify/txn.go 45.08% <0.00%> (ø)
ledger/acctupdates.go 62.80% <0.00%> (+0.16%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f774e7e...2614bc0. Read the comment docs.

Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - one small request in changing %v to %w so we can identify the original issue.

cmd/goal/commands.go Outdated Show resolved Hide resolved
@tsachiherman tsachiherman merged commit bd5a000 into algorand:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants