Ensure that AssetCreator is not used before proto.LogicSigVersion=5 #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also unifies a lot of field handling so that the code is less susceptible to copy-paste errors, but it has a ways to go. Hard to both unify the handling of the different fields and use separate types for each field index. Lots and lots of interfaces could do. Or generics in 6 months? For the moment, each field type is a pile of arrays and maps working together. It's unclear what we gain from those separate index types, since we *always* cast into the type just before using them, as we are getting the indexes from reading a byte in bytecode.
algorandskiy
approved these changes
Aug 23, 2021
algojack
pushed a commit
to algojack/go-algorand
that referenced
this pull request
Aug 24, 2021
…lgorand#2784) This also unifies a lot of field handling so that the code is less susceptible to copy-paste errors, but it has a ways to go. Hard to both unify the handling of the different fields and use separate types for each field index. Lots and lots of interfaces could do. Or generics in 6 months? For the moment, each field type is a pile of arrays and maps working together. It's unclear what we gain from those separate index types, since we always cast into the type just before using them, as we are getting the indexes from reading a byte in bytecode. New tests will catch this mistake if we make it again.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also unifies a lot of field handling so that the code is less
susceptible to copy-paste errors, but it has a ways to go. Hard to
both unify the handling of the different fields and use separate
types for each field index. Lots and lots of interfaces could do. Or
generics in 6 months? For the moment, each field type is a pile of
arrays and maps working together.
It's unclear what we gain from those separate index types, since
we always cast into the type just before using them, as we are
getting the indexes from reading a byte in bytecode.
New tests will catch this mistake if we make it again.