Bugfix/fix nano s enumeration bug #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just built and tested this and wanted to confirm it resolves the issues I was having here #2665 Thank you @algoidan 👍 |
Codecov Report
@@ Coverage Diff @@
## master #2822 +/- ##
=======================================
Coverage 47.12% 47.12%
=======================================
Files 349 349
Lines 56430 56430
=======================================
+ Hits 26590 26591 +1
+ Misses 26860 26857 -3
- Partials 2980 2982 +2
Continue to review full report at Codecov.
|
tsachiherman
reviewed
Sep 1, 2021
| // The usb library adds one extra byte to the input passed to the USB device | ||
| // so the written bytes are larger than what we've send | ||
| // https://github.com/karalabe/hid/blob/9c14560f9ee858c43f40b5cd01392b167aacf4e8/hid_enabled.go#L167 | ||
| if runtime.GOOS == "windows" && cc > 0 { |
There was a problem hiding this comment.
consider refactoring so you would use ledger_windows.go for windows-specific logic.
tsachiherman
reviewed
Sep 1, 2021
tsachiherman
reviewed
Sep 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal was not able to communicate with the Ledger Nano S device.
The device has two HID occurrences on the OS and after the firmware upgrade, one of them became not responsive. That made goal to the hang.