Fix pingpong teal test

[egieseke]

Summary

Updated the netgoal utility to only create one wallet per non-participating node to better concentrate Algos for use by pingpong.

Test Plan

Ran netgoal to update the scenario2 recipe and tested the result with the CICD performance pipeline.

[codecov-commenter]

Codecov Report

Merging #2835 (d3a27a5) into master (ac51e70) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2835      +/-   ##
==========================================
- Coverage   47.12%   47.09%   -0.03%     
==========================================
  Files         349      349              
  Lines       56434    56434              
==========================================
- Hits        26593    26580      -13     
- Misses      26859    26869      +10     
- Partials     2982     2985       +3     

Impacted Files	Coverage Δ
network/wsPeer.go	72.14% <0.00%> (-3.07%)	⬇️
crypto/merkletrie/trie.go	66.42% <0.00%> (-2.19%)	⬇️
crypto/merkletrie/node.go	91.62% <0.00%> (-1.87%)	⬇️
catchup/service.go	69.35% <0.00%> (-0.78%)	⬇️
network/wsNetwork.go	61.09% <0.00%> (+0.18%)	⬆️
ledger/acctupdates.go	62.46% <0.00%> (+0.33%)	⬆️
network/requestTracker.go	71.12% <0.00%> (+0.86%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac51e70...d3a27a5. Read the comment docs.

[tsachiherman]

looks good to me. Please make sure to regenerate all the scenarios with this change and include them in the PR.

[tsachiherman]

Changing the total supply can trigger some failures that would not be possible on mainnet. Are we truely ran out of money?

[onetechnical]

Changing the total supply can trigger some failures that would not be possible on mainnet. Are we truely ran out of money?

+1. I'm still not a fan of increasing the amount of supply, as it indicates an unrealistic test (we would never increase mainnet supply).

[algobarb]

Messaged Eric to learn more about the details. The results look correct on Datadog now so I think the last fix to rebalance stake fixed it! Changes look good to me.

[egieseke]

looks good to me. Please make sure to regenerate all the scenarios with this change and include them in the PR.

Updated scenario1 and scenario3.

[egieseke]

Changing the total supply can trigger some failures that would not be possible on mainnet. Are we truely ran out of money?

By rebalancing the stake between participating and non-participating nodes, increasing the total stake is not required. Reverted total stake back to 10 billion Algos.

[algobarb]

Looks like Scenario1 results look ok with the rebalanced stake and removed wallets as well. Looks good to me.

[egieseke]

Changing the total supply can trigger some failures that would not be possible on mainnet. Are we truely ran out of money?

+1. I'm still not a fan of increasing the amount of supply, as it indicates an unrealistic test (we would never increase mainnet supply).

@onetechnical Good point. Updated so that the total stake remains at 10 billion. Split stake evenly between participating and nonparticipating nodes, which provides a sufficient amount for the teal pingpong tests.

[bricerisingalgorand]

Have we always been assuming an even split between participating and non participating nodes? I wonder if that should be configurable. It looks like that would be a new feature though so probably out of scope

[egieseke]

It was evenly split before. I will create a ticket to make it configurable.

[egieseke]

Created this ticket to allow configuration of stake ratio: https://github.com/algorand/go-algorand-internal/issues/1566

Resolved