Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global GroupID #2838

Merged
merged 1 commit into from
Sep 7, 2021
Merged

global GroupID #2838

merged 1 commit into from
Sep 7, 2021

Conversation

jannotti
Copy link
Contributor

@jannotti jannotti commented Sep 4, 2021

Add GroupID as an accessible global field in AVM.

Co-authored-by: Zach Langley zachary.langley@algorand.com

Add GroupID as an accessible global field in AVM.

Co-authored-by: Zach Langley <zachary.langley@algorand.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2021

Codecov Report

Merging #2838 (ec208f0) into master (e32b2c2) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2838      +/-   ##
==========================================
- Coverage   47.28%   47.27%   -0.02%     
==========================================
  Files         351      351              
  Lines       56381    56385       +4     
==========================================
- Hits        26659    26654       -5     
- Misses      26730    26738       +8     
- Partials     2992     2993       +1     
Impacted Files Coverage Δ
data/transactions/logic/doc.go 82.75% <ø> (ø)
data/transactions/logic/fields.go 83.58% <ø> (ø)
data/transactions/logic/fields_string.go 4.65% <0.00%> (-0.04%) ⬇️
data/transactions/logic/eval.go 89.20% <100.00%> (+0.01%) ⬆️
agreement/cryptoVerifier.go 75.73% <0.00%> (-2.21%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
catchup/service.go 69.35% <0.00%> (-0.78%) ⬇️
network/wsNetwork.go 60.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e32b2c2...ec208f0. Read the comment docs.

@jannotti jannotti self-assigned this Sep 4, 2021
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@jannotti jannotti merged commit 8a0d699 into algorand:master Sep 7, 2021
@jannotti jannotti deleted the groupid-field branch September 7, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants