tx_field tables #2849
Merged
tx_field tables #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannotti
force-pushed
the
txfield-tables
branch
from
a5ef5a4
to
04c6b6f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2849 +/- ##
==========================================
+ Coverage 47.28% 47.33% +0.05%
==========================================
Files 351 351
Lines 56488 56506 +18
==========================================
+ Hits 26708 26745 +37
+ Misses 26765 26752 -13
+ Partials 3015 3009 -6
Continue to review full report at Codecov.
|
brianolson
reviewed
Sep 8, 2021
| @@ -18,7 +18,7 @@ Ops have a 'cost' of 1 unless otherwise specified. | |||
| - SHA256 hash of value X, yields [32]byte | |||
| - **Cost**: | |||
| - 7 (LogicSigVersion = 1) | |||
| - 35 (2 <= LogicSigVersion <= 5) | |||
| - 35 (LogicSigVersion => 2) | |||
There was a problem hiding this comment.
>= would be more conventional, and less confused with an arrow?
There was a problem hiding this comment.
oh, geez, you're right of course. thanks.
algorandskiy
approved these changes
Sep 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drive the checking of whether tx_field can set a particular field in a table-driven way, rather than by simple switch. This is cleaner as we add functionality in later versions, and will allow generating the spec for tx_field.