Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loads and stores opcodes that take scratch slot from stack #2853

Merged
merged 4 commits into from
Sep 8, 2021

Conversation

jannotti
Copy link
Contributor

@jannotti jannotti commented Sep 7, 2021

Lots of fixups for not checking unit64 to int casts as well.

@jannotti jannotti force-pushed the stack-scratch branch 3 times, most recently from f85bba3 to f81d0a7 Compare September 8, 2021 04:13
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #2853 (52d6c86) into master (cde7eed) will increase coverage by 0.02%.
The diff coverage is 60.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2853      +/-   ##
==========================================
+ Coverage   47.28%   47.30%   +0.02%     
==========================================
  Files         351      351              
  Lines       56488    56505      +17     
==========================================
+ Hits        26708    26730      +22     
- Misses      26765    26768       +3     
+ Partials     3015     3007       -8     
Impacted Files Coverage Δ
cmd/goal/clerk.go 9.11% <0.00%> (ø)
data/transactions/logic/doc.go 82.75% <ø> (ø)
data/transactions/logic/opcodes.go 96.00% <ø> (ø)
data/transactions/verify/txn.go 44.29% <0.00%> (-0.80%) ⬇️
data/transactions/logic/assembler.go 80.66% <34.61%> (ø)
data/transactions/logic/eval.go 88.96% <75.00%> (+0.07%) ⬆️
cmd/tealdbg/local.go 70.50% <100.00%> (ø)
daemon/algod/api/server/v2/dryrun.go 61.79% <100.00%> (ø)
data/transactions/logic/debugger.go 51.42% <100.00%> (ø)
ledger/eval.go 76.82% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cde7eed...52d6c86. Read the comment docs.

algochoi
algochoi previously approved these changes Sep 8, 2021
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Had one comment about naming. Thanks for fixing the txnas related parts 👍

data/transactions/logic/eval.go Show resolved Hide resolved
Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jannotti jannotti merged commit 6afa86b into algorand:master Sep 8, 2021
@jannotti jannotti deleted the stack-scratch branch September 8, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants