Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with checking RUN_EXPECT when listing packages #2863

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

cce
Copy link
Contributor

@cce cce commented Sep 9, 2021

Summary

@algoidan noticed we were not running some non-expect e2e-go tests and we spotted this issue in the test script when checking the value of RUN_EXPECT.

Test Plan

Check to ensure non-expect e2e-go tests are run as expected.

Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #2863 (f0793b8) into master (6afa86b) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2863      +/-   ##
==========================================
+ Coverage   47.34%   47.35%   +0.01%     
==========================================
  Files         351      351              
  Lines       56523    56523              
==========================================
+ Hits        26758    26765       +7     
+ Misses      26758    26752       -6     
+ Partials     3007     3006       -1     
Impacted Files Coverage Δ
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
ledger/catchpointwriter.go 68.18% <0.00%> (-1.30%) ⬇️
catchup/service.go 68.57% <0.00%> (-0.78%) ⬇️
data/transactions/verify/txn.go 44.29% <0.00%> (ø)
ledger/acctupdates.go 62.63% <0.00%> (+0.08%) ⬆️
agreement/proposalManager.go 98.03% <0.00%> (+1.96%) ⬆️
agreement/cryptoVerifier.go 77.94% <0.00%> (+2.20%) ⬆️
network/wsPeer.go 75.20% <0.00%> (+3.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6afa86b...f0793b8. Read the comment docs.

@algojohnlee algojohnlee merged commit b8b7281 into master Sep 9, 2021
@algojohnlee algojohnlee deleted the fix-expect-test-split branch September 9, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants