Introduce itxn to get inner transaction results #2883
Conversation
This only changes the blocks, so there is still a lot of work to do so that external APIs see things properly. The REST API assumes that it can determine a creatble ID based on the index of a transaction in a block and the block's TxnCounter. That is no longer true, it must actually figure out how many inner txns it is skipping over.
This also sorts out inner txcounting, so that an innner transaction knows the current txncount as it executes, so it can get the right id if it creates.
Test inner txn indexes
Codecov Report
@@ Coverage Diff @@
## master #2883 +/- ##
==========================================
- Coverage 47.28% 42.94% -4.35%
==========================================
Files 355 353 -2
Lines 56901 57177 +276
==========================================
- Hits 26908 24552 -2356
- Misses 26958 29616 +2658
+ Partials 3035 3009 -26
Continue to review full report at Codecov.
|
|
FYI: the required CircleCI tetsts clearly passed, as did all the other required tests, so I'm not sure why this is reporting that checks haven't completed yet. I would consider this a passed tests result, at least as of commit 24c76af. |
| tx_field Receiver | ||
| tx_submit | ||
| itxn_field Receiver | ||
| itxn_submit |
There was a problem hiding this comment.
not sure if it fits but consider adding new itxn opcode into e2e test
There was a problem hiding this comment.
I do one in the integration test (not true e2e). I will add a e2e sub test while in betanet (after making it so I can use python!)
There was a problem hiding this comment.
yes, these e2e_subs tests are shared with the indexer so it is worth having new opcodes/side effects here
This allows axfer and afrz, and adds itxn so that the new asset id can be read.