Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: fix unit test data race #2926

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

tsachiherman
Copy link
Contributor

Summary

The unit test TestLatestSigsFromThisNode was data racing. The fix is trivial.

Test Plan

This is a test.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #2926 (19ffe30) into master (dbab85f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2926   +/-   ##
=======================================
  Coverage   47.29%   47.29%           
=======================================
  Files         356      356           
  Lines       57240    57240           
=======================================
+ Hits        27071    27072    +1     
  Misses      27103    27103           
+ Partials     3066     3065    -1     
Impacted Files Coverage Δ
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
catchup/service.go 68.57% <0.00%> (-1.56%) ⬇️
ledger/acctupdates.go 62.13% <0.00%> (-0.42%) ⬇️
cmd/tealdbg/debugger.go 73.86% <0.00%> (+1.00%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
network/wsPeer.go 74.37% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbab85f...19ffe30. Read the comment docs.

Copy link
Contributor

@algonautshant algonautshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants