testing: fix failure in TestAccountInformationV2 #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3049 +/- ##
==========================================
- Coverage 43.64% 43.64% -0.01%
==========================================
Files 391 391
Lines 86779 86779
==========================================
- Hits 37877 37872 -5
- Misses 42872 42875 +3
- Partials 6030 6032 +2
Continue to review full report at Codecov.
|
algorandskiy
approved these changes
Oct 13, 2021
|
@algorandskiy thanks. |
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
Oct 28, 2021
## Summary The test had a conceptual buggy pattern. It was using ```golang round, err = client.CurrentRound() ... _, err = client.BroadcastTransaction(signedTxn) ... _, err = client.WaitForRound(round + 3) ``` which is doomed to fail if the test process goes to sleep for a minute between the `client.CurrentRound()` call and the `client.BroadcastTransaction` call. The trivial solution is to reorder the calls so that ```golang _, err = client.BroadcastTransaction(signedTxn) ... round, err = client.CurrentRound() ... _, err = client.WaitForRound(round + 3) ``` ## Test Plan This is a test.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The test had a conceptual buggy pattern. It was using
which is doomed to fail if the test process goes to sleep for a minute between the
client.CurrentRound()call and theclient.BroadcastTransactioncall. The trivial solution is to reorder the calls so thatTest Plan
This is a test.