Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LookupAgreement in AlgorandFullNode.VotingKeys() #3050

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Oct 13, 2021

Summary

Use LookupAgreement in AlgorandFullNode.VotingKeys()

Post #3046 fixes.

Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #3050 (2ed29fa) into master (a957519) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3050      +/-   ##
==========================================
+ Coverage   43.64%   43.67%   +0.02%     
==========================================
  Files         389      391       +2     
  Lines       86774    86792      +18     
==========================================
+ Hits        37872    37904      +32     
+ Misses      42869    42862       -7     
+ Partials     6033     6026       -7     
Impacted Files Coverage Δ
node/node.go 3.69% <0.00%> (ø)
network/wsNetwork.go 62.95% <0.00%> (-0.19%) ⬇️
libgoal/lockedFileUnix.go 0.00% <0.00%> (ø)
util/db/fullfsync_darwin.go 100.00% <0.00%> (ø)
ledger/acctupdates.go 66.53% <0.00%> (+0.09%) ⬆️
util/db/dbutil.go 39.54% <0.00%> (+0.56%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
ledger/catchpointwriter.go 69.48% <0.00%> (+1.29%) ⬆️
catchup/service.go 70.12% <0.00%> (+1.55%) ⬆️
util/metrics/counter.go 80.95% <0.00%> (+2.38%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a957519...2ed29fa. Read the comment docs.

@tsachiherman tsachiherman merged commit c4bfc26 into algorand:master Oct 13, 2021
cce pushed a commit to cce/go-algorand that referenced this pull request Oct 28, 2021
## Summary

Use LookupAgreement in AlgorandFullNode.VotingKeys()

Post algorand#3046 fixes.
@egieseke egieseke mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants