Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing CircleCI deploy for Betanet and Stablenet #3077

Merged
merged 38 commits into from
Oct 15, 2021

Conversation

algojack
Copy link
Contributor

@algojack algojack commented Oct 14, 2021

Noticed our environment passing variable is not working as intended, implemented a different way of passing it.

please squash merge when merging

algobarb
algobarb previously approved these changes Oct 14, 2021
@algojack
Copy link
Contributor Author

algojack commented Oct 14, 2021

please squash merge when merging

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #3077 (0af2ece) into master (019571e) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3077      +/-   ##
==========================================
+ Coverage   43.66%   43.67%   +0.01%     
==========================================
  Files         391      391              
  Lines       86845    86845              
==========================================
+ Hits        37917    37929      +12     
+ Misses      42895    42889       -6     
+ Partials     6033     6027       -6     
Impacted Files Coverage Δ
data/transactions/verify/txn.go 43.42% <0.00%> (-0.88%) ⬇️
catchup/service.go 68.57% <0.00%> (-0.78%) ⬇️
network/wsPeer.go 73.31% <0.00%> (-0.78%) ⬇️
network/wsNetwork.go 63.14% <0.00%> (+0.18%) ⬆️
ledger/acctupdates.go 64.65% <0.00%> (+0.39%) ⬆️
data/abi/abi_type.go 91.81% <0.00%> (+0.90%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
ledger/blockqueue.go 83.90% <0.00%> (+2.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 019571e...0af2ece. Read the comment docs.

@algojohnlee algojohnlee merged commit ffb49ef into algorand:master Oct 15, 2021
@algojack algojack deleted the circleci-deploy-devnet branch October 15, 2021 15:00
algojohnlee added a commit that referenced this pull request Oct 15, 2021
Fixing CircleCI deploy for Betanet and Stablenet (#3077)
cce pushed a commit to cce/go-algorand that referenced this pull request Oct 28, 2021
Noticed our environment passing variable is not working as intended, implemented a different way of passing it.
@egieseke egieseke mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants