-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tealdbg: use associated group index instead of global #3111
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3111 +/- ##
==========================================
+ Coverage 43.68% 43.70% +0.01%
==========================================
Files 390 390
Lines 86681 86681
==========================================
+ Hits 37868 37881 +13
+ Misses 42796 42774 -22
- Partials 6017 6026 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely a bug, thanks for fixing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
setting group index to be the one associated with the run
Summary
The
groupIndex
variable is a global set by a flag and defaults to 0. In themain.go
file its checked and then set in DebugParams.I believe this is a bug that affects any grouped transactions where the groupIndex meant to be evaluated is > 0 and we should really be using the groupIndex passed in the
evaluation
struct.Test Plan
Existing tests