Trim the whitespaces before/after each line of TEAL code #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3128 +/- ##
===========================================
- Coverage 43.68% 32.04% -11.64%
===========================================
Files 390 388 -2
Lines 86681 86664 -17
===========================================
- Hits 37863 27773 -10090
- Misses 42801 54762 +11961
+ Partials 6017 4129 -1888
Continue to review full report at Codecov.
|
|
This is nice! It also might be prudent to have a test in |
jannotti
approved these changes
Oct 25, 2021
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
Oct 28, 2021
Trimming the whitespaces before and after each line in TEAL code. In algorand#2168, white space before #pragma version XXX leads to a failure in inferring the TEAL version. Relaxing assembler rules resolves the issue. Closes algorand#2168.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Trimming the whitespaces before and after each line in TEAL code.
In #2168, white space before
#pragma version XXXleads to a failure in inferring the TEAL version. Relaxing assembler rules resolves the issue.Closes #2168.