Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make heapwatch.py port configurable #3143

Merged
merged 3 commits into from
Oct 28, 2021

Conversation

bricerisingalgorand
Copy link
Contributor

@bricerisingalgorand bricerisingalgorand commented Oct 26, 2021

Summary

This makes it possible to configure which port algod is running on when using heapWatch.py

Test Plan

I tested this by running it against betanet and checking which port is getting used when the new arg is/isn't added.

@bricerisingalgorand bricerisingalgorand changed the title Make port configurable Make heapwatch.py port configurable Oct 26, 2021
algojack
algojack previously approved these changes Oct 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #3143 (70f850d) into master (729e597) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3143   +/-   ##
=======================================
  Coverage   43.78%   43.78%           
=======================================
  Files         391      391           
  Lines       86880    86880           
=======================================
+ Hits        38038    38042    +4     
+ Misses      42808    42806    -2     
+ Partials     6034     6032    -2     
Impacted Files Coverage Δ
util/metrics/gauge.go 68.00% <0.00%> (-2.67%) ⬇️
util/metrics/counter.go 78.57% <0.00%> (-2.39%) ⬇️
network/requestTracker.go 70.25% <0.00%> (-0.87%) ⬇️
data/abi/abi_type.go 93.03% <0.00%> (ø)
ledger/acctupdates.go 64.75% <0.00%> (+0.09%) ⬆️
network/wsPeer.go 71.46% <0.00%> (+0.26%) ⬆️
ledger/blockqueue.go 82.18% <0.00%> (+1.14%) ⬆️
txnsync/mainloop.go 87.32% <0.00%> (+1.40%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729e597...70f850d. Read the comment docs.

@algojohnlee algojohnlee merged commit c56ecc2 into algorand:master Oct 28, 2021
cce pushed a commit to cce/go-algorand that referenced this pull request Oct 28, 2021
This makes it possible to configure which port algod is running on when using heapWatch.py
@egieseke egieseke mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants