Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Local structure definition to localTemplate #3161

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

tsachiherman
Copy link
Contributor

Summary

Move Local structure definition to localTemplate, so that changes to localTemplate are more obvious to be a change of template than a change of data.

Test Plan

Tested manually.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #3161 (94ac8b7) into master (465c191) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3161      +/-   ##
==========================================
- Coverage   43.80%   43.80%   -0.01%     
==========================================
  Files         391      392       +1     
  Lines       86880    86880              
==========================================
- Hits        38062    38059       -3     
- Misses      42786    42790       +4     
+ Partials     6032     6031       -1     
Impacted Files Coverage Δ
config/config.go 47.05% <ø> (-0.77%) ⬇️
config/localTemplate.go 50.00% <50.00%> (ø)
util/metrics/gauge.go 68.00% <0.00%> (-2.67%) ⬇️
util/metrics/counter.go 78.57% <0.00%> (-2.39%) ⬇️
data/abi/abi_type.go 92.03% <0.00%> (-1.00%) ⬇️
catchup/service.go 69.07% <0.00%> (-0.75%) ⬇️
network/wsPeer.go 72.53% <0.00%> (-0.27%) ⬇️
network/wsNetwork.go 65.39% <0.00%> (ø)
ledger/acctupdates.go 64.75% <0.00%> (+0.49%) ⬆️
network/latencyTracker.go 70.21% <0.00%> (+4.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 465c191...94ac8b7. Read the comment docs.

@tsachiherman tsachiherman merged commit 9ca31f8 into algorand:master Oct 29, 2021
@tsachiherman tsachiherman deleted the tsachi/configfile branch October 29, 2021 16:21
tsachiherman added a commit to tsachiherman/go-algorand that referenced this pull request Nov 2, 2021
tsachiherman added a commit to tsachiherman/go-algorand that referenced this pull request Nov 3, 2021
Move Local structure definition to localTemplate, so that changes to localTemplate are more obvious to be a change of template than a change of data.

Tested manually.
cce pushed a commit to cce/go-algorand that referenced this pull request Nov 3, 2021
Move Local structure definition to localTemplate, so that changes to localTemplate are more obvious to be a change of template than a change of data.

Tested manually.
@egieseke egieseke mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants