Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Participation Key Interface #3164

Merged
merged 31 commits into from
Nov 15, 2021
Merged

Participation Key Interface #3164

merged 31 commits into from
Nov 15, 2021

Conversation

winder
Copy link
Contributor

@winder winder commented Oct 29, 2021

Summary

  • new ParticipationRegistry interface designed to manage keys and collect usage metrics.
  • new REST endpoints for interacting with keys.
  • improved goal account partkeyinfo and goal account listpartkeys formatting.

Test Plan

New unit and integration tests.

util/db/initialize_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #3164 (0ab926c) into master (d3bbe62) will increase coverage by 0.34%.
The diff coverage is 51.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3164      +/-   ##
==========================================
+ Coverage   47.12%   47.47%   +0.34%     
==========================================
  Files         366      369       +3     
  Lines       58675    59494     +819     
==========================================
+ Hits        27653    28244     +591     
- Misses      27804    27970     +166     
- Partials     3218     3280      +62     
Impacted Files Coverage Δ
agreement/abstractions.go 50.00% <ø> (ø)
agreement/agreementtest/keyManager.go 100.00% <ø> (ø)
config/config.go 47.05% <ø> (ø)
daemon/algod/api/server/v2/handlers.go 0.00% <0.00%> (ø)
daemon/algod/api/server/v2/test/helpers.go 74.81% <0.00%> (-2.29%) ⬇️
data/accountManager.go 0.00% <0.00%> (ø)
libgoal/libgoal.go 2.93% <0.00%> (-0.09%) ⬇️
libgoal/participation.go 0.00% <0.00%> (ø)
logging/testingLogger.go 0.00% <ø> (ø)
util/db/dbutil.go 41.80% <ø> (+2.25%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3bbe62...0ab926c. Read the comment docs.

@winder winder marked this pull request as ready for review November 3, 2021 21:38
node/node.go Outdated Show resolved Hide resolved
agreement/pseudonode.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants