use large VMs for integration tests #3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3201 +/- ##
==========================================
- Coverage 47.19% 47.16% -0.04%
==========================================
Files 365 365
Lines 58369 58369
==========================================
- Hits 27550 27529 -21
- Misses 27631 27649 +18
- Partials 3188 3191 +3
Continue to review full report at Codecov.
|
winder
previously approved these changes
Nov 9, 2021
|
lgtm but we should figure out avg daily cost and compare before and after we merge this. |
algojack
approved these changes
Nov 10, 2021
winder
approved these changes
Nov 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integration tests (specifically, e2e-go tests) seem to be having resource issues lately, so this returns integration tests to using large instances (4 cores, ~16GB RAM) after they were downsized to medium (2 cores ~8GB RAM) in #3095. Nightly integration tests are already using large VMs.
Test Plan
Hopefully this will improve integration test performance and reduce flakiness by giving E2E go tests (which typically involve spinning up multiple algod processes) more CPU and RAM.