goal abi method outfile checking

[barnjamin]

Check if the outFilename argument is passed and write to the path specified as other commands

[ahangsu]

LGTM

[codecov-commenter]

Codecov Report

Merging #3204 (bf1d28a) into master (d3bbe62) will decrease coverage by 0.01%.
The diff coverage is 30.76%.

@@            Coverage Diff             @@
##           master    #3204      +/-   ##
==========================================
- Coverage   47.12%   47.11%   -0.02%     
==========================================
  Files         366      366              
  Lines       58675    58681       +6     
==========================================
- Hits        27653    27645       -8     
- Misses      27804    27816      +12     
- Partials     3218     3220       +2     

Impacted Files	Coverage Δ
cmd/goal/application.go	12.77% <30.76%> (-0.45%)	⬇️
ledger/roundlru.go	90.56% <0.00%> (-5.67%)	⬇️
ledger/blockqueue.go	81.03% <0.00%> (-4.03%)	⬇️
catchup/service.go	69.07% <0.00%> (-0.75%)	⬇️
network/wsPeer.go	68.05% <0.00%> (-0.56%)	⬇️
data/transactions/verify/txn.go	44.29% <0.00%> (ø)
network/requestTracker.go	71.12% <0.00%> (+0.86%)	⬆️
ledger/acctupdates.go	65.96% <0.00%> (+0.95%)	⬆️
data/abi/abi_type.go	93.03% <0.00%> (+0.99%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3bbe62...bf1d28a. Read the comment docs.

[jannotti]

What are these and why did they go away?

[ahangsu]

Suppose we want to support foreignAssets/foreignApp/etc., we can pass that in cmd line and I suppose they can also be passed from a file, right?
This was left from previous #3088 about if keeping argument for foreignApp etc., and I think the option should be available and kept

[jasonpaulos]

The only things that went away are:

methodAppCmd.Flags().MarkHidden("app-input") // nolint:errcheck
methodAppCmd.Flags().MarkHidden("i")         // nolint:errcheck

They are both flags which specify a JSON input file which can contain foreign references (and app args, but we already handle these properly). Since we want to allow specifying additional foreign references, I think it makes sense to keep this flag unhidden.

[jasonpaulos]

Mostly good, I just have one suggestion

[jasonpaulos]

The only things that went away are:

methodAppCmd.Flags().MarkHidden("app-input") // nolint:errcheck
methodAppCmd.Flags().MarkHidden("i")         // nolint:errcheck

They are both flags which specify a JSON input file which can contain foreign references (and app args, but we already handle these properly). Since we want to allow specifying additional foreign references, I think it makes sense to keep this flag unhidden.