Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify get_ex opcode docs #3208

Merged
merged 2 commits into from
Nov 13, 2021
Merged

Conversation

barnjamin
Copy link
Contributor

The app_{local|global}_get_ex opcode will return 0 for exists flag if the app or key don't exist.

@jannotti
Copy link
Contributor

jannotti commented Nov 12, 2021

Be sure to run make in data/transactions/logic and check in the spec changes that result.

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #3208 (df8f483) into master (d3bbe62) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3208   +/-   ##
=======================================
  Coverage   47.12%   47.13%           
=======================================
  Files         366      366           
  Lines       58675    58675           
=======================================
+ Hits        27653    27658    +5     
+ Misses      27804    27798    -6     
- Partials     3218     3219    +1     
Impacted Files Coverage Δ
data/transactions/logic/doc.go 77.41% <ø> (ø)
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
network/wsNetwork.go 62.84% <0.00%> (-0.20%) ⬇️
data/transactions/verify/txn.go 44.29% <0.00%> (ø)
network/requestTracker.go 71.12% <0.00%> (+0.86%) ⬆️
network/wsPeer.go 70.83% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3bbe62...df8f483. Read the comment docs.

Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jannotti jannotti merged commit 3937401 into algorand:master Nov 13, 2021
@egieseke egieseke mentioned this pull request Nov 23, 2021
@barnjamin barnjamin deleted the opcode-getex-clarify branch December 16, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants