Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix : tx sync was incorrectly validating transactions #3554

Merged
merged 4 commits into from
Feb 2, 2022

Conversation

tsachiherman
Copy link
Contributor

Summary

The TestSyncFromClient was randomly failing. This is a real issue in production code, and the fix it pretty trivial.

Test Plan

Use existing tests to verify test.

algonautshant
algonautshant previously approved these changes Feb 2, 2022
Copy link
Contributor

@algonautshant algonautshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
Just one issue.

rpcs/txSyncer.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #3554 (49b6c39) into master (1dd40a8) will decrease coverage by 0.02%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3554      +/-   ##
==========================================
- Coverage   47.59%   47.57%   -0.03%     
==========================================
  Files         370      370              
  Lines       60109    60114       +5     
==========================================
- Hits        28609    28598      -11     
- Misses      28189    28201      +12     
- Partials     3311     3315       +4     
Impacted Files Coverage Δ
rpcs/txSyncer.go 74.54% <16.66%> (-5.46%) ⬇️
ledger/acctupdates.go 65.58% <0.00%> (-0.96%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
catchup/service.go 69.38% <0.00%> (-0.75%) ⬇️
network/wsNetwork.go 62.79% <0.00%> (-0.20%) ⬇️
network/wsPeer.go 68.05% <0.00%> (ø)
data/transactions/verify/txn.go 44.44% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dd40a8...49b6c39. Read the comment docs.

@tsachiherman tsachiherman merged commit 6230dc5 into algorand:master Feb 2, 2022
@tsachiherman tsachiherman deleted the tsachi/txsyncerbugfix branch February 2, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants