Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving windows build to Github Actions #3575

Merged
merged 62 commits into from
Feb 11, 2022

Conversation

algojack
Copy link
Contributor

@algojack algojack commented Feb 4, 2022

Moved it to build-test-windows here on Github.
Artifact gathering and upload are not currently working, since they seem to be cached files and we are not sure how useful those are. But if we can determine what exactly we need and for what purpose, we can add them back in.

Slack notifications for failed nightly builds added using slack webhook to #dev-alerts channel.
Travis integration removed.

Example slack message:
image

@algojack algojack self-assigned this Feb 4, 2022
@algojack algojack changed the title Moving windows build to circleci Moving windows build to Github Actions Feb 7, 2022
@algojack algojack marked this pull request as ready for review February 7, 2022 22:33
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #3575 (41f7577) into master (6230dc5) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3575      +/-   ##
==========================================
- Coverage   47.58%   47.58%   -0.01%     
==========================================
  Files         370      370              
  Lines       60118    60118              
==========================================
- Hits        28606    28605       -1     
- Misses      28198    28199       +1     
  Partials     3314     3314              
Impacted Files Coverage Δ
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
agreement/cryptoVerifier.go 75.17% <0.00%> (-2.13%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
ledger/acctupdates.go 65.58% <0.00%> (-1.15%) ⬇️
network/wsPeer.go 68.33% <0.00%> (-0.84%) ⬇️
data/transactions/verify/txn.go 44.44% <0.00%> (ø)
catchup/service.go 69.38% <0.00%> (+0.74%) ⬆️
cmd/tealdbg/debugger.go 73.86% <0.00%> (+1.00%) ⬆️
network/requestTracker.go 71.55% <0.00%> (+1.29%) ⬆️
ledger/tracker.go 75.75% <0.00%> (+1.29%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6230dc5...41f7577. Read the comment docs.

onetechnical
onetechnical previously approved these changes Feb 8, 2022
Copy link
Contributor

@onetechnical onetechnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The python version is interesting, but otherwise looks alright to me.

@algojack
Copy link
Contributor Author

algojack commented Feb 8, 2022

The python version is interesting, but otherwise looks alright to me.

Removed, got it from circleci attempt to implement this, but seems we don't need it.

@algojohnlee algojohnlee merged commit 3f34164 into master Feb 11, 2022
@algojohnlee algojohnlee deleted the Moving-windows-build-to-circleci branch February 11, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants