Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catchpointdump into tools package #3590

Merged
merged 3 commits into from
Feb 8, 2022

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Feb 8, 2022

Summary

Having catchpointdump in tools looks as not a bad idea in general.
In particular I need a linux build of catchpointdump on my Mac machine in order
to plug it into algonet linux network. The only way to make such a cross build is calling
deploy_linux_version.sh that builds and upload packages in a docker container.

Modified create_and_deploy_recipe.sh to support multicomponent GOPATH

Test Plan

Tested manually and it works as expected:

  1. catchpointdump is in tools package
  2. Multicomponent GOPATH supported well
  3. Content of tmp/go-cache is not sent into docker

@tsachiherman
Copy link
Contributor

please test this and let me know if it works as expected.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

Merging #3590 (9035873) into master (bc9cebd) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3590      +/-   ##
==========================================
- Coverage   47.58%   47.54%   -0.04%     
==========================================
  Files         370      370              
  Lines       60092    60092              
==========================================
- Hits        28595    28573      -22     
- Misses      28185    28200      +15     
- Partials     3312     3319       +7     
Impacted Files Coverage Δ
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
ledger/acctupdates.go 65.58% <0.00%> (-0.96%) ⬇️
catchup/service.go 68.64% <0.00%> (-0.75%) ⬇️
network/wsPeer.go 68.05% <0.00%> (-0.56%) ⬇️
network/wsNetwork.go 62.79% <0.00%> (-0.20%) ⬇️
data/abi/abi_type.go 88.62% <0.00%> (ø)
network/requestTracker.go 71.12% <0.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc9cebd...9035873. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants