Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a fallback for missing state proof keys in participation file #3619

Merged

Conversation

Aharonee
Copy link
Contributor

@Aharonee Aharonee commented Feb 13, 2022

Summary

Restoring participation has failed in the nightly build, since it was trying to query for StateProofKeys table which doesn't exist yet.

Made sure to call the migration in the correct places to fix this issue.

Test Plan

Unit tests added.

@Aharonee Aharonee marked this pull request as ready for review February 13, 2022 18:13
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2022

Codecov Report

Merging #3619 (0a1bfae) into master (53b157b) will increase coverage by 0.02%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3619      +/-   ##
==========================================
+ Coverage   48.05%   48.07%   +0.02%     
==========================================
  Files         381      381              
  Lines       62074    62080       +6     
==========================================
+ Hits        29829    29847      +18     
+ Misses      28822    28814       -8     
+ Partials     3423     3419       -4     
Impacted Files Coverage Δ
node/node.go 23.33% <0.00%> (-0.08%) ⬇️
data/account/participation.go 64.10% <50.00%> (-1.12%) ⬇️
...merklesignature/persistentMerkleSignatureScheme.go 65.27% <100.00%> (ø)
data/account/account.go 40.00% <100.00%> (+2.50%) ⬆️
ledger/blockqueue.go 81.03% <0.00%> (-4.03%) ⬇️
network/wsPeer.go 68.88% <0.00%> (-0.28%) ⬇️
network/wsNetwork.go 62.99% <0.00%> (+0.19%) ⬆️
catchup/service.go 69.38% <0.00%> (+0.49%) ⬆️
data/transactions/verify/txn.go 45.02% <0.00%> (+0.86%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53b157b...0a1bfae. Read the comment docs.

tsachiherman
tsachiherman previously approved these changes Feb 13, 2022
@id-ms id-ms changed the title Hotfix - restore participation database without state proof fails add a fallback for missing state proof keys in participation file Feb 13, 2022
tsachiherman
tsachiherman previously approved these changes Feb 13, 2022
@id-ms id-ms force-pushed the hotfix-restore-participation-stateproof branch from 79b6ba2 to 0a1bfae Compare February 13, 2022 20:32
@tsachiherman tsachiherman merged commit 212edb3 into algorand:master Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants