-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a fallback for missing state proof keys in participation file #3619
Merged
tsachiherman
merged 6 commits into
algorand:master
from
Aharonee:hotfix-restore-participation-stateproof
Feb 13, 2022
Merged
add a fallback for missing state proof keys in participation file #3619
tsachiherman
merged 6 commits into
algorand:master
from
Aharonee:hotfix-restore-participation-stateproof
Feb 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3619 +/- ##
==========================================
+ Coverage 48.05% 48.07% +0.02%
==========================================
Files 381 381
Lines 62074 62080 +6
==========================================
+ Hits 29829 29847 +18
+ Misses 28822 28814 -8
+ Partials 3423 3419 -4
Continue to review full report at Codecov.
|
tsachiherman
previously approved these changes
Feb 13, 2022
id-ms
changed the title
Hotfix - restore participation database without state proof fails
add a fallback for missing state proof keys in participation file
Feb 13, 2022
tsachiherman
previously approved these changes
Feb 13, 2022
id-ms
force-pushed
the
hotfix-restore-participation-stateproof
branch
from
February 13, 2022 20:32
79b6ba2
to
0a1bfae
Compare
tsachiherman
approved these changes
Feb 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restoring participation has failed in the nightly build, since it was trying to query for StateProofKeys table which doesn't exist yet.
Made sure to call the migration in the correct places to fix this issue.
Test Plan
Unit tests added.