API: Fix prove bug on API #3632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3632 +/- ##
==========================================
+ Coverage 48.11% 48.13% +0.02%
==========================================
Files 381 381
Lines 62214 62217 +3
==========================================
+ Hits 29933 29951 +18
+ Misses 28848 28837 -11
+ Partials 3433 3429 -4
Continue to review full report at Codecov.
|
| s, _, _ := blk.DecodeSignedTxn(blk.Payset[i]) | ||
| t.Log(s.Txn.ID()) | ||
| } | ||
| t.FailNow() |
There was a problem hiding this comment.
I think that the intent here is correct - but you should log more useful information that would help you to debug the issue further.
In particular, I'd suggest dumping the entire confirmedTx ( which includes the block number ), as well as the entire block.
There was a problem hiding this comment.
thanks for the advice
id-ms
force-pushed
the
test-txnmerkel
branch
6 times, most recently
from
fcd76d2
to
a1f81db
Compare
id-ms
force-pushed
the
test-txnmerkel
branch
from
a1f81db
to
349b0be
Compare
id-ms
force-pushed
the
test-txnmerkel
branch
from
2a6e9f3
to
e8002dc
Compare
id-ms
force-pushed
the
test-txnmerkel
branch
from
e8002dc
to
d5d2d3e
Compare
id-ms
force-pushed
the
test-txnmerkel
branch
from
c27da92
to
1c92a95
Compare
tsachiherman
approved these changes
Feb 22, 2022
tsachiherman
changed the title
Closed
This was referenced Feb 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug on algod's API. When a tree contains a missing child (not a full tree), the api handler omits this from the proof response and leads to a root mismatch
Test Plan
Add unit tests as well as convert the e2e to test this edge case.