Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goal node create improvements #3639

Merged
merged 4 commits into from Feb 22, 2022

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Feb 16, 2022

Summary

  1. --full-config options allows saving config file with all options, not only non-default.
  2. Embed genesis.json for mainnet, testnet, betanet, devnet

Test Plan

Tested manually

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #3639 (7035846) into master (c6c6e8b) will increase coverage by 1.75%.
The diff coverage is 99.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3639      +/-   ##
==========================================
+ Coverage   48.06%   49.82%   +1.75%     
==========================================
  Files         381      382       +1     
  Lines       62080    64264    +2184     
==========================================
+ Hits        29841    32019    +2178     
- Misses      28818    28823       +5     
- Partials     3421     3422       +1     
Impacted Files Coverage Δ
config/localTemplate.go 42.85% <0.00%> (-7.15%) ⬇️
cmd/goal/node.go 10.90% <6.66%> (+0.39%) ⬆️
cmd/goal/bundledGenesisInject.go 100.00% <100.00%> (ø)
network/wsPeer.go 65.83% <0.00%> (-3.34%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
catchup/service.go 69.38% <0.00%> (-0.75%) ⬇️
network/wsNetwork.go 62.99% <0.00%> (+0.19%) ⬆️
network/requestTracker.go 71.12% <0.00%> (+0.86%) ⬆️
data/transactions/verify/txn.go 45.02% <0.00%> (+0.86%) ⬆️
ledger/blockqueue.go 85.05% <0.00%> (+2.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6c6e8b...7035846. Read the comment docs.

jasonpaulos
jasonpaulos previously approved these changes Feb 16, 2022
Copy link
Member

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me

cmd/goal/node.go Outdated Show resolved Hide resolved
@algorandskiy
Copy link
Contributor Author

@tsachiherman followed your suggestion and embedded genesis files.

winder
winder previously approved these changes Feb 17, 2022
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@algorandskiy
Copy link
Contributor Author

Closes #1686

Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@tsachiherman tsachiherman merged commit eb4af44 into algorand:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants