New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevOps: Regen net.json for scenario2 test to include api endpoints for nodes. #3654
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3654 +/- ##
==========================================
- Coverage 48.12% 48.12% -0.01%
==========================================
Files 381 381
Lines 62214 62214
==========================================
- Hits 29939 29938 -1
+ Misses 28847 28844 -3
- Partials 3428 3432 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Looks good, but does opening these API endpoints impact the amount of traffic going to telemetry? Just trying to still understand why Prometheus recently went down. |
Thanks for removing netaddress for scenario2. Should we also remove it everywhere else that we recently added it to, before we forget? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for removing the NetAddress from custom and scenario2.
These endpoints allow the bandwidth tool to communicate with the nodes and collect the bandwidth data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary
Regen scenario 2 net.json file to include API endpoints for nodes.
Test Plan
Testing with scenario2 recipe with cicd perf pipeline.