Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer Tools: Add manjaro support to build script #3893

Merged
merged 1 commit into from
May 27, 2022

Conversation

vuvoth
Copy link
Contributor

@vuvoth vuvoth commented Apr 16, 2022

Summary

Close #3894.
Fix install dependencies on manjaro linux.

Please check it! Thanks <3

Test Plan

On my local machine.

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2022

Codecov Report

Merging #3893 (254d01c) into master (8a5155f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3893      +/-   ##
==========================================
+ Coverage   50.02%   50.03%   +0.01%     
==========================================
  Files         393      393              
  Lines       68295    68295              
==========================================
+ Hits        34166    34173       +7     
+ Misses      30428    30423       -5     
+ Partials     3701     3699       -2     
Impacted Files Coverage Δ
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
catchup/service.go 69.62% <0.00%> (+0.74%) ⬆️
data/abi/abi_type.go 88.62% <0.00%> (+0.94%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
agreement/proposalManager.go 98.03% <0.00%> (+1.96%) ⬆️
agreement/cryptoVerifier.go 69.71% <0.00%> (+2.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a5155f...254d01c. Read the comment docs.

@algorandskiy
Copy link
Contributor

manjaro is not in the supported OS's list. @algojohnlee opinion?

Copy link
Contributor

@onetechnical onetechnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't explicitly support arch or manjaro, but this seems like a small enough change to add support.

@algojohnlee algojohnlee changed the title fix: build script on manjaro Developer Tools: Add manjaro support to build script May 27, 2022
@algojohnlee algojohnlee merged commit 9237316 into algorand:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails on manjaro
5 participants