Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algokey: Add -v flag to get the version #4004

Merged
merged 1 commit into from
May 18, 2022

Conversation

algoganesh
Copy link
Contributor

Summary

Algokey was missing a way to tell what version it's using. One should be able to run algokey -v and get the same output as goal -v.

Test Plan

algokey -v gives the same output as goal -v

@algoganesh algoganesh requested a review from winder May 17, 2022 21:54
@algoganesh algoganesh linked an issue May 17, 2022 that may be closed by this pull request
@winder winder changed the title Algokey: Added version -v subcommand Algokey: Add -v flag to get the version May 17, 2022
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #4004 (ad7df6e) into master (8bb8a4a) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4004      +/-   ##
==========================================
+ Coverage   49.80%   49.83%   +0.02%     
==========================================
  Files         409      409              
  Lines       69157    69157              
==========================================
+ Hits        34447    34462      +15     
+ Misses      30992    30981      -11     
+ Partials     3718     3714       -4     
Impacted Files Coverage Δ
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
network/wsNetwork.go 62.99% <0.00%> (ø)
ledger/acctupdates.go 69.43% <0.00%> (+0.65%) ⬆️
ledger/tracker.go 76.62% <0.00%> (+1.29%) ⬆️
network/wsPeer.go 70.55% <0.00%> (+1.66%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb8a4a...ad7df6e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AlgoKey: Add version subcommand
3 participants