AVM: base64_decode can decode padded or unpadded encodings #4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4015 +/- ##
==========================================
+ Coverage 54.44% 54.48% +0.04%
==========================================
Files 390 390
Lines 48500 48509 +9
==========================================
+ Hits 26406 26432 +26
+ Misses 19867 19855 -12
+ Partials 2227 2222 -5
Continue to review full report at Codecov.
|
tzaffi
reviewed
May 20, 2022
data/transactions/logic/eval_test.go
Outdated
| {"cGFk====", "StdEncoding", "pad", "input byte 4"}, | ||
|
|
||
| // Test that padding must be present to make len = 0 mod 4. | ||
| // Test that padding must be correct of absent |
There was a problem hiding this comment.
Suggested change
| // Test that padding must be correct of absent | |
| // Test that padding must be correct or absent |
There was a problem hiding this comment.
ha, single character typos can be confusing. I meant "or".
tzaffi
previously approved these changes
May 20, 2022
This was referenced May 27, 2022
This was referenced Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base64 decoding now operates on padded or unpadded encodings. Since \r and \n are ignored while decoding, the approach we take is to look for padding, and use the padded encoding if we find any, or raw if we don't. (This contrasts with how we (I?) expected to do it - by checking if the padding was correct and stripping it off. But that would require scanning the string, not just checking the length.)