Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICD: upgrade xcode on circleci macos executors #4188

Merged
merged 2 commits into from Jun 29, 2022

Conversation

algolucky
Copy link
Contributor

@algolucky algolucky commented Jun 28, 2022

Summary

  • upgrades xcode to 13.4.1 since CircleCI is planning to deprecate the version we are using

  • removes s from sleep commands in testInfraTest.exp expect tests b/c newer versions of macos do not allow that syntax anymore

  • CircleCI Forum Discussion on Xcode Deprecation

Test Plan

  • see circleci tests

@algolucky algolucky changed the title CICD: upgrade xcode on macos executors CICD: upgrade xcode on circleci macos executors Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #4188 (3d386a1) into master (688b3d7) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4188      +/-   ##
==========================================
- Coverage   54.56%   54.52%   -0.05%     
==========================================
  Files         391      391              
  Lines       48734    48734              
==========================================
- Hits        26593    26572      -21     
- Misses      19919    19933      +14     
- Partials     2222     2229       +7     
Impacted Files Coverage Δ
network/wsPeer.go 65.47% <0.00%> (-4.94%) ⬇️
util/metrics/reporter.go 56.31% <0.00%> (-4.86%) ⬇️
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
catchup/service.go 68.88% <0.00%> (-0.75%) ⬇️
network/wsNetwork.go 64.70% <0.00%> (-0.20%) ⬇️
data/transactions/verify/txn.go 44.88% <0.00%> (+0.88%) ⬆️
data/abi/abi_type.go 88.62% <0.00%> (+0.94%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 688b3d7...3d386a1. Read the comment docs.

@algolucky algolucky marked this pull request as ready for review June 29, 2022 00:27
Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for troubleshooting the sleep error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants